Skip to content

RxJS 7 #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

RxJS 7 #774

wants to merge 11 commits into from

Conversation

CarsonF
Copy link
Contributor

@CarsonF CarsonF commented Sep 18, 2021

  • Change throwError usage to pass error creator
  • Replace flatMap import with mergeMap
  • Replace concat import with concatWith
  • Replace toPromise with lastValueFrom
  • Replace Notification instances with plain objects
  • Replace publishReplay + refCount with shareReplay
  • Simplify RxTransaction & RxSession using from & defer

I didn't update the lock file because I have a newer version of npm and updated the entire file. Hopefully a maintainer can commit this.

@bigmontz
Copy link
Contributor

bigmontz commented Oct 5, 2021

Hi @CarsonF,

Thanks for contributing and sorry for the delayed response.

This PR is a potential breaking change due to the use of RxJS 7, https://rxjs.dev/deprecations/breaking-changes. We will defer this change until the next major release (5.0) when we can merge the PR.

@bigmontz bigmontz added the 5.0 PR which should be merged to the 5.0 version label Oct 5, 2021
@bigmontz
Copy link
Contributor

Hi @CarsonF,

For your PR be able to be reviewed, you need to read and sign Neo4j's CLA (https://neo4j.com/developer/cla/).

Thanks.

@CarsonF
Copy link
Contributor Author

CarsonF commented Jan 26, 2022

Hey @bigmontz, I did send the CLA email back when I opened the PR. Should I send again?

@bigmontz
Copy link
Contributor

Hey @CarsonF, thanks for the response. I've found your agreement.

Could you please rebase and change the branch target to 5.0?

@bigmontz
Copy link
Contributor

Since rebase on top of 5.0 was not done in time for the 5.0 window, the feature was re-implemented in #927. Sorry for the inconvenience, but this PR will be closed.

Thanks for contributing.

@bigmontz bigmontz closed this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.0 PR which should be merged to the 5.0 version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarsonF @bigmontz